Conversation
…effect, replace with height/width where it had to fix scaling in Safari
unekinn
requested review from
Barsnes,
eirikbacker,
mimarz and
oddvernes
as code owners
🦋 Changeset detectedLatest commit: b1780fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: storybook - themebuilder - www - |
|
Just noticed a lot of icons on the front page don't scale on firefox |
|
@oddvernes how strange. It scales fine in my Firefox (147.0.3) Cards: Footer: |
|
Weird, Im on same firefox, macbook. But its seems to mainly be noticeable at pretty high zoom like 200% (with cmd +) and above so it is not as bad as safari. perhaps it is flex-shrink or something |
| "@digdir/designsystemet-css": patch | ||
| --- | ||
|
|
||
| **Badge, Button, Spinner, Tabs, Tag**: Icons now scale in Safari when zooming |
There was a problem hiding this comment.
Is there a side effect with how this was implemented that fontSize on the svg in these components now has an effect? Because I think it should be mentined here if so (considering how many examples there were of this in our own code)
2 participants
Summary
Changes icon sizing css from using
font-size, which breaks scaling when zooming in Safari, to using height and widthFixes #4038
Checks
pnpm changesetif relevant)